Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8139173: [macosx] JInternalFrame shadow is not properly drawn #1101

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented May 19, 2022

Backport JDK-8139173

Clean backport except Copyright year


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8139173: [macosx] JInternalFrame shadow is not properly drawn

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1101/head:pull/1101
$ git checkout pull/1101

Update a local copy of the PR:
$ git checkout pull/1101
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1101

View PR using the GUI difftool:
$ git pr show -t 1101

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1101.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f7814c120bf84d7e9b459f81a6ce19b44fa122ec 8139173: [macosx] JInternalFrame shadow is not properly drawn May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 19, 2022
@mlbridge
Copy link

mlbridge bot commented May 19, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented May 19, 2022

Hi, If this is clean except for copyright, please note it in the PR description, too, and use the / clean command.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified fix on M1.

@openjdk
Copy link

openjdk bot commented May 19, 2022

@takiguc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8139173: [macosx] JInternalFrame shadow is not properly drawn

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 4f29d1e: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
  • 39fd29f: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • 00ee3ff: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • 364ed1d: 8234608: [TESTBUG] Fix G1 redefineClasses tests and a memory leak
  • 281aeb9: 8264179: [TESTBUG] Some compiler tests fail when running without C2
  • d05bd5f: 8163498: Many long-running security libs tests
  • 0629ea6: 8209920: runtime/logging/RedefineClasses.java fail with OOME with ZGC
  • fef9e84: 8209150: [TESTBUG] Add logging to verify JDK-8197901 to a different test
  • 8f85dcf: 8285686: Update FreeType to 2.12.0
  • 80c9f24: 8235220: ClhsdbScanOops.java fails with sun.jvm.hotspot.types.WrongTypeException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 19, 2022
@takiguc
Copy link
Author

takiguc commented May 19, 2022

/clean

@openjdk openjdk bot added the clean label May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

@takiguc This backport pull request is now marked as clean

@takiguc
Copy link
Author

takiguc commented May 23, 2022

jdk17u-fix-yes was verified.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@takiguc Unknown command integrage - for a list of valid commands use /help.

@takiguc
Copy link
Author

takiguc commented May 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2022

Going to push as commit d6003fe.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 8533ba4: 7124301: [macosx] When in a tab group if you arrow between tabs there are no VoiceOver announcements.
  • 3072af4: 8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test
  • 7265ae5: 7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.
  • ab5b6a9: 8214275: CondyRepeatFailedResolution asserts "Dynamic constant has no fixed basic type"
  • cb1a537: 8133713: [macosx] Accessible JTables always reported as empty
  • 2b75da6: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • eb2d6b8: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • 4f29d1e: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
  • 39fd29f: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • 00ee3ff: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/0056b9b4f91ed9132364984fb45e1ce1ad563af4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2022
@openjdk openjdk bot closed this May 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@takiguc Pushed as commit d6003fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants