Skip to content

8222799: java.beans.Introspector uses an obsolete methods cache#1106

Closed
basil wants to merge 1 commit intoopenjdk:masterfrom
basil:declaredMethodCache
Closed

8222799: java.beans.Introspector uses an obsolete methods cache#1106
basil wants to merge 1 commit intoopenjdk:masterfrom
basil:declaredMethodCache

Conversation

@basil
Copy link
Contributor

@basil basil commented May 24, 2022

Hi all,

This pull request contains a backport of JDK-8222799 (openjdk/jdk@921b46738e0).

The only merge conflicts in Introspector.java were copyrights and imports, which were trivially fixed.

The commit being backported was authored by @mrserb on October 20, 2020, and was reviewed by prr.

See #1103 (review) for the motivation for this backport; namely, it would be cleaner to backport this first in order to then be able to backport JDK-8231454 without conflicts.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8222799: java.beans.Introspector uses an obsolete methods cache

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1106/head:pull/1106
$ git checkout pull/1106

Update a local copy of the PR:
$ git checkout pull/1106
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1106

View PR using the GUI difftool:
$ git pr show -t 1106

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1106.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2022

👋 Welcome back basil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 921b46738e0c3aaa2bf8c62e0accb0a5056190d3 8222799: java.beans.Introspector uses an obsolete methods cache May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 24, 2022
@mlbridge
Copy link

mlbridge bot commented May 24, 2022

Webrevs

@basil
Copy link
Contributor Author

basil commented May 24, 2022

I do not have JBS access. Can someone please submit the following comment with the jdk11u-fix-request label:

It would be cleaner to backport this first in order to then be able to backport JDK-8231454 without conflicts. I tested this PR as part of testing the backport of JDK-8231454.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost clean. LGTM. I've added the request and the label to the JBS issue.

@openjdk
Copy link

openjdk bot commented May 24, 2022

@basil This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8222799: java.beans.Introspector uses an obsolete methods cache

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d71a543: 8287119: Add Distrust.java to ProblemList

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2022
@basil
Copy link
Contributor Author

basil commented May 25, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 25, 2022
@openjdk
Copy link

openjdk bot commented May 25, 2022

@basil
Your change (at version 11652aa) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

Problems in Pre-submit tests on Windows were observed without this PR, too.
/sponsor

@openjdk
Copy link

openjdk bot commented May 25, 2022

Going to push as commit 69bdf9b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d71a543: 8287119: Add Distrust.java to ProblemList

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2022
@openjdk openjdk bot closed this May 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 25, 2022
@openjdk
Copy link

openjdk bot commented May 25, 2022

@TheRealMDoerr @basil Pushed as commit 69bdf9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@basil basil deleted the declaredMethodCache branch May 25, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants