Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256215: Shenandoah: re-organize saving/restoring machine state in assembler code #111

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 8, 2021

This improves Shenandoah support on x86_32. There were numerous failures on lower UseSSE modes, which this patch is supposed to fix. The notable differences from the upstream is the absence of LRB-native code, which does not exist in 11u. Ditto for nmethod barriers that also do not exist in 11u.

Additional testing:

  • Linux x86_64 fastdebug hotspot_gc_shenandoah
  • Linux x86_64 fastdebug tier1 with Shenandoah
  • Linux x86_32 fastdebug hotspot_gc_shenandoah with default, SSE=1, SSE=2
  • Linux x86_32 fastdebug tier1 with Shenandoah default, SSE=1, SSE=2
  • Linux x86_32 fastdebug tier2 with Shenandoah default, SSE=1, SSE=2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256215: Shenandoah: re-organize saving/restoring machine state in assembler code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/111/head:pull/111
$ git checkout pull/111

Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 111

View PR using the GUI difftool:
$ git pr show -t 111

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/111.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a97aedff9f622ba6816b7550588f1d429bff2483 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jul 27, 2021

Friendly reminder. @rkennke, @zhengyu123?

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 27, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256215: Shenandoah: re-organize saving/restoring machine state in assembler code

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • f700d37: 8255255: Update Apache Santuario (XML Signature) to version 2.2.1
  • 227610d: 8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes
  • d7a6e51: 8253899: Make IsClassUnloadingEnabled signature match specification
  • 293d44f: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • ... and 49 more: https://git.openjdk.java.net/jdk11u-dev/compare/2beb7e7a5834c45850e1bde8d98ed0839726db20...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2021
@shipilev
Copy link
Member Author

shipilev commented Jul 28, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

Going to push as commit eaf59e0.
Since your change was applied there have been 59 commits pushed to the master branch:

  • f700d37: 8255255: Update Apache Santuario (XML Signature) to version 2.2.1
  • 227610d: 8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes
  • d7a6e51: 8253899: Make IsClassUnloadingEnabled signature match specification
  • 293d44f: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • ... and 49 more: https://git.openjdk.java.net/jdk11u-dev/compare/2beb7e7a5834c45850e1bde8d98ed0839726db20...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@shipilev Pushed as commit eaf59e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8256215 branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants