-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256215: Shenandoah: re-organize saving/restoring machine state in assembler code #111
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Friendly reminder. @rkennke, @zhengyu123? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 59 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Got the push approval. /integrate |
Going to push as commit eaf59e0.
Your commit was automatically rebased without conflicts. |
This improves Shenandoah support on x86_32. There were numerous failures on lower
UseSSE
modes, which this patch is supposed to fix. The notable differences from the upstream is the absence of LRB-native code, which does not exist in 11u. Ditto for nmethod barriers that also do not exist in 11u.Additional testing:
hotspot_gc_shenandoah
tier1
with Shenandoahhotspot_gc_shenandoah
with default, SSE=1, SSE=2tier1
with Shenandoah default, SSE=1, SSE=2tier2
with Shenandoah default, SSE=1, SSE=2Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/111/head:pull/111
$ git checkout pull/111
Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/111/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 111
View PR using the GUI difftool:
$ git pr show -t 111
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/111.diff