Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287362: FieldAccessWatch testcase failed on AIX platform #1112

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented May 29, 2022

Backport JDK-8287362

Backport is not clean.
I applied following changes:

  • Remove following files, they are not in jdk11u
    • test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMethods.cpp
    • test/hotspot/jtreg/runtime/jni/FastGetField/libFastGetField.c
  • Modify following file, just Copyright year
    • test/hotspot/jtreg/serviceability/jvmti/FieldAccessWatch/libFieldAccessWatch.c

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287362: FieldAccessWatch testcase failed on AIX platform

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1112/head:pull/1112
$ git checkout pull/1112

Update a local copy of the PR:
$ git checkout pull/1112
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1112

View PR using the GUI difftool:
$ git pr show -t 1112

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1112.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2022

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 66340372d595aeb4b3dfd9169a8448f363097256 8287362: FieldAccessWatch testcase failed on AIX platform May 29, 2022
@openjdk
Copy link

openjdk bot commented May 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels May 29, 2022
@mlbridge
Copy link

mlbridge bot commented May 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 30, 2022

@takiguc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287362: FieldAccessWatch testcase failed on AIX platform

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 370730f: 8181571: printing to CUPS fails on mac sandbox app
  • 6faebb1: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 30, 2022
@takiguc
Copy link
Author

takiguc commented May 30, 2022

jdk11u-fix-yes is verified

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2022

Going to push as commit 27d4c1e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • de59d51: 8285397: JNI exception pending in CUPSfuncs.c:250
  • 370730f: 8181571: printing to CUPS fails on mac sandbox app
  • 6faebb1: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 30, 2022
@openjdk openjdk bot closed this May 30, 2022
@openjdk openjdk bot removed ready rfr labels May 30, 2022
@openjdk
Copy link

openjdk bot commented May 30, 2022

@takiguc Pushed as commit 27d4c1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants