New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8240903: Add test to check that jmod hashes are reproducible #1115
Conversation
Reviewed-by: alanb
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifications LGTM.
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Windows GHA unrelated, will be fixed via openjdk/jdk11u#39 |
/integrate |
Going to push as commit b3c0cc9.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit b3c0cc9. |
This backports a test which should have been added with JDK-8240734 in first place.
I had to do a few modifications to make it work in 11, extracted into the second commit. In 11, Files::mismatch is missing and jmod does not have the option --date.
I verified that the test fails without the changes of JDK-8240734 and passes now with it.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1115/head:pull/1115
$ git checkout pull/1115
Update a local copy of the PR:
$ git checkout pull/1115
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1115/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1115
View PR using the GUI difftool:
$ git pr show -t 1115
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1115.diff