Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240903: Add test to check that jmod hashes are reproducible #1115

Closed
wants to merge 2 commits into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 29, 2022

This backports a test which should have been added with JDK-8240734 in first place.
I had to do a few modifications to make it work in 11, extracted into the second commit. In 11, Files::mismatch is missing and jmod does not have the option --date.
I verified that the test fails without the changes of JDK-8240734 and passes now with it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8240903: Add test to check that jmod hashes are reproducible

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1115/head:pull/1115
$ git checkout pull/1115

Update a local copy of the PR:
$ git checkout pull/1115
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1115

View PR using the GUI difftool:
$ git pr show -t 1115

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1115.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 29, 2022
@mlbridge
Copy link

mlbridge bot commented May 29, 2022

Webrevs

@RealCLanger RealCLanger changed the title 8240903: Add test to check that jmod hashes are reproducible Backport 9695283458c273c2a4121f88a2a971ad4f297d5b May 30, 2022
@openjdk openjdk bot changed the title Backport 9695283458c273c2a4121f88a2a971ad4f297d5b 8240903: Add test to check that jmod hashes are reproducible May 30, 2022
@openjdk
Copy link

openjdk bot commented May 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 30, 2022
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications LGTM.

@openjdk
Copy link

openjdk bot commented May 30, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240903: Add test to check that jmod hashes are reproducible

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 370730f: 8181571: printing to CUPS fails on mac sandbox app
  • 6faebb1: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 30, 2022
@RealCLanger
Copy link
Contributor Author

Windows GHA unrelated, will be fixed via openjdk/jdk11u#39

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 3, 2022

Going to push as commit b3c0cc9.
Since your change was applied there have been 10 commits pushed to the master branch:

  • a2e6494: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
  • e7036ec: 8283017: GHA: Workflows break with update release versions
  • 866f8f5: 8287202: GHA: Add macOS aarch64 to the list of default platforms for workflow_dispatch event
  • 25ac222: 8287017: Bump update version for OpenJDK: jdk-11.0.17
  • 1c93a6e: 8285720: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails to compile after backport of 8273655
  • 7b58ca2: 8284094: Memory leak in invoker_completeInvokeRequest()
  • 27d4c1e: 8287362: FieldAccessWatch testcase failed on AIX platform
  • de59d51: 8285397: JNI exception pending in CUPSfuncs.c:250
  • 370730f: 8181571: printing to CUPS fails on mac sandbox app
  • 6faebb1: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2022
@openjdk openjdk bot closed this Jun 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2022
@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@RealCLanger Pushed as commit b3c0cc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-8240903 branch June 3, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants