Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups #1118

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 30, 2022

The backport needed some resolving/adaptation to older zipfs code.
Method IndexNode:toString is not implemented, so this part of the upstream patch does not apply.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1118/head:pull/1118
$ git checkout pull/1118

Update a local copy of the PR:
$ git checkout pull/1118
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1118

View PR using the GUI difftool:
$ git pr show -t 1118

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1118.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 80cf9f3464c599fb7860432bf4ed506a3b298d8e 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups May 30, 2022
@openjdk
Copy link

openjdk bot commented May 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 30, 2022
@mlbridge
Copy link

mlbridge bot commented May 30, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

Closing in favor of openjdk/jdk11u#38

@RealCLanger RealCLanger closed this Jun 1, 2022
@RealCLanger RealCLanger deleted the RealCLanger-backport-80cf9f34 branch Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant