Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE #112

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 8, 2021

Fixes a test x86_32.

Additional testing:

  • Affected test on x86_32 with -XX:UseSSE=1, used to fail, now passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/112/head:pull/112
$ git checkout pull/112

Update a local copy of the PR:
$ git checkout pull/112
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 112

View PR using the GUI difftool:
$ git pr show -t 112

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/112.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a14f02d8e59156a26c3509e21f2b19bf23cb7c1d 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2021

Going to push as commit 1960a05.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 6d0945e: 8217825: Verify @AfterTest is used correctly in WebSocket tests
  • 3869a19: 8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference
  • 2c49cca: 8240555: Using env of JAVA_TOOL_OPTIONS and _JAVA_OPTIONS breaks QuietOption.java test
  • 3ce8c72: 8268635: Corrupt oop in ClassLoaderData
  • 7bc4f40: 8261238: NMT should not limit baselining by size threshold
  • 591d769: 8263407: SPARC64 detection fails on Athena (SPARC64-X)
  • 509170c: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2021
@openjdk
Copy link

openjdk bot commented Jul 11, 2021

@shipilev Pushed as commit 1960a05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant