Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 7, 2022

I backport this for parity with 11.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1125/head:pull/1125
$ git checkout pull/1125

Update a local copy of the PR:
$ git checkout pull/1125
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1125

View PR using the GUI difftool:
$ git pr show -t 1125

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1125.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d3022f87b598398d7130e984088ede6ffc9f48e1 8282467: add extra diagnostics for JDK-8268184 Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282467: add extra diagnostics for JDK-8268184

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 8, 2022

Pre-submit failure:
windows: known, unrelated issue.
ppc64le: ifg.cpp:765:30: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long long unsigned int'
fegetround() from /usr/include/fenv.h seems to have the wrong type.

@RealCLanger
Copy link
Contributor

Pre-submit failure: windows: known, unrelated issue. ppc64le: ifg.cpp:765:30: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long long unsigned int' fegetround() from /usr/include/fenv.h seems to have the wrong type.

Looks like the GHA template for linuxppc64le could need a little tweaking?

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2022

@GoeLin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2022

@GoeLin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants