8268360: Missing check for infinite loop during node placement

[TheRealMDoerr]

11.0.13-oracle has implemented some error detection and bail out (see JBS). The test is publicly available as JDK-8268417. It also fails without the fix in OpenJDK 11u.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8268360: Missing check for infinite loop during node placement
• JDK-8268417: Add test from JDK-8268360

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/113/head:pull/113
$ git checkout pull/113

Update a local copy of the PR:
$ git checkout pull/113
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 113

View PR using the GUI difftool:
$ git pr show -t 113

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/113.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[TheRealMDoerr]

/solves JDK-8268417

[openjdk]

@TheRealMDoerr
Adding additional issue to solves list: 8268417: Add test from JDK-8268360.

[mlbridge]

Webrevs

• 00: Full (a4cd301f)

[rwestrel]

Looks good to me.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268360: Missing check for infinite loop during node placement
8268417: Add test from JDK-8268360

Reviewed-by: roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 1960a05: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE
• 6d0945e: 8217825: Verify @AfterTest is used correctly in WebSocket tests
• 3869a19: 8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference
• 2c49cca: 8240555: Using env of JAVA_TOOL_OPTIONS and _JAVA_OPTIONS breaks QuietOption.java test
• 3ce8c72: 8268635: Corrupt oop in ClassLoaderData
• 7bc4f40: 8261238: NMT should not limit baselining by size threshold
• 591d769: 8263407: SPARC64 detection fails on Athena (SPARC64-X)
• 509170c: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

[TheRealMDoerr]

Thanks for the review and the approval!
/integrate

[openjdk]

Going to push as commit 22a4752.
Since your change was applied there have been 8 commits pushed to the master branch:

• 1960a05: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE
• 6d0945e: 8217825: Verify @AfterTest is used correctly in WebSocket tests
• 3869a19: 8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference
• 2c49cca: 8240555: Using env of JAVA_TOOL_OPTIONS and _JAVA_OPTIONS breaks QuietOption.java test
• 3ce8c72: 8268635: Corrupt oop in ClassLoaderData
• 7bc4f40: 8261238: NMT should not limit baselining by size threshold
• 591d769: 8263407: SPARC64 detection fails on Athena (SPARC64-X)
• 509170c: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 22a4752.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.