Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment #1132

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jun 8, 2022

A clean backport to fix memory leaks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1132/head:pull/1132
$ git checkout pull/1132

Update a local copy of the PR:
$ git checkout pull/1132
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1132

View PR using the GUI difftool:
$ git pr show -t 1132

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1132.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 8, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cbe7e7bd7f7e7ea9f7221ef206917c58baff7696 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 8, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • bb5d2bb: 8239902: [macos] Remove direct usage of JSlider, JProgressBar classes in CAccessible class
  • 16d0b7d: 8210107: vmTestbase/nsk/stress/network tests fail with Cannot assign requested address (Bind failed)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Jun 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

Going to push as commit ab7d1ca.
Since your change was applied there have been 47 commits pushed to the master branch:

  • d7b6f7f: 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root
  • 1fbbd15: 8287366: Improve test failure reporting in GHA
  • 8363d9d: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled
  • 27faf15: 8273526: Extend the OSContainer API pids controller with pids.current
  • 6c389cd: 8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"
  • 43e6fdb: 8281569: Create tests for Frame.setMinimumSize() method
  • f129738: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
  • e16aaca: 8253829: Wrong length compared in SSPI bridge
  • 1c1f7a1: 8210722: JAXP Tests: CatalogSupport2 and CatalogSupport3 generate incorrect messages upon failure
  • 8138382: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
  • ... and 37 more: https://git.openjdk.org/jdk11u-dev/compare/a665027fb79fdf750c180d24ac4b586320994b76...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jun 28, 2022
@openjdk openjdk bot closed this Jun 28, 2022
@openjdk openjdk bot removed ready rfr labels Jun 28, 2022
@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@zhengyu123 Pushed as commit ab7d1ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant