Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed #1137

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 9, 2022

I backport this for parity with 11.0.17-oracle.

Copyright resolve only.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1137/head:pull/1137
$ git checkout pull/1137

Update a local copy of the PR:
$ git checkout pull/1137
$ git pull https://git.openjdk.org/jdk11u-dev pull/1137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1137

View PR using the GUI difftool:
$ git pr show -t 1137

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1137.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cc54de76ca9e8d52cf58a240ca05ad30799b8471 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 9, 2022

/clean

@openjdk openjdk bot added the clean label Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 39109e5: 8209736: runtime/RedefineTests/ModifyAnonymous.java fails with NullPointerException when running in CDS mode
  • cc6137c: 8069343: Improve gc/g1/TestHumongousCodeCacheRoots.java to use jtreg @requires
  • a87bfb8: 8286114: [test] show real exception in bomb call in sun/rmi/runtime/Log/checkLogging/CheckLogging.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 13, 2022

PreSubmit failure: TestMetaspacePerfCounters.java#id3 konwn to be failing eventually, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Jun 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

Going to push as commit 97a472c.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2022
@openjdk openjdk bot closed this Jun 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin Pushed as commit 97a472c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8264400 branch June 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant