Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268635: Corrupt oop in ClassLoaderData #114

Closed

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Jul 8, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/114/head:pull/114
$ git checkout pull/114

Update a local copy of the PR:
$ git checkout pull/114
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 114

View PR using the GUI difftool:
$ git pr show -t 114

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/114.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 8, 2021

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3586a233a49c979e87fed9df148d0bf3df2df38b 8268635: Corrupt oop in ClassLoaderData Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@earthling-amzn This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268635: Corrupt oop in ClassLoaderData

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@earthling-amzn
Copy link
Contributor Author

@earthling-amzn earthling-amzn commented Jul 8, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@earthling-amzn
Your change (at version 2cd1725) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Webrevs

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jul 9, 2021

@earthling-amzn You should add jdk11u-fix-request tag and "Fix Request" comment for 11u maintainers approvals first.

@earthling-amzn
Copy link
Contributor Author

@earthling-amzn earthling-amzn commented Jul 9, 2021

/tag jdk11u-fix-request

Fix Request

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@earthling-amzn Unknown command tag - for a list of valid commands use /help.

@earthling-amzn
Copy link
Contributor Author

@earthling-amzn earthling-amzn commented Jul 9, 2021

@shipilev - Guessing I should do this on the JBS ticket?

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jul 9, 2021

@shipilev - Guessing I should do this on the JBS ticket?

Yes. https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 10, 2021

I approved it.

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 10, 2021

Going to push as commit 3ce8c72.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 7bc4f40: 8261238: NMT should not limit baselining by size threshold
  • 591d769: 8263407: SPARC64 detection fails on Athena (SPARC64-X)
  • 509170c: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 10, 2021

@RealCLanger @earthling-amzn Pushed as commit 3ce8c72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants