Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283849: AsyncGetCallTrace may crash JVM on guarantee #1148

Closed

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Jun 14, 2022

A fairly straightforward backport.

There are only two types of minor adjustments that had to be done:

  • line number adjustments due to the difference in thread.cpp/hpp files
  • missing Thread->as_java_thread() function - can be exactly replicated by ((JavaThread*)current_thread) cast

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283849: AsyncGetCallTrace may crash JVM on guarantee

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1148/head:pull/1148
$ git checkout pull/1148

Update a local copy of the PR:
$ git checkout pull/1148
$ git pull https://git.openjdk.org/jdk11u-dev pull/1148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1148

View PR using the GUI difftool:
$ git pr show -t 1148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2022

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 19639855311a47ed532547743ea3873eb8b016d3 8283849: AsyncGetCallTrace may crash JVM on guarantee Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 14, 2022
@jbachorik jbachorik force-pushed the jbachorik-backport-19639855 branch from d1249db to cf4694c Compare June 14, 2022 17:20
@jbachorik
Copy link
Contributor Author

/label hotspot

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@jbachorik
The label hotspot is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Jun 14, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@jbachorik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283849: AsyncGetCallTrace may crash JVM on guarantee

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 538794f: Merge
  • 1dd942d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • c64f12c: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
  • 2632f54: 8287109: Distrust.java failed with CertificateExpiredException
  • 68f6fbb: 8284754: print more interesting env variables in hs_err and VM.info

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2022
@jbachorik
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

Going to push as commit 684f12e.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 8e94c68: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ffd8dc2: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
  • 538794f: Merge
  • 1dd942d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • c64f12c: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
  • 2632f54: 8287109: Distrust.java failed with CertificateExpiredException
  • 68f6fbb: 8284754: print more interesting env variables in hs_err and VM.info

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2022
@openjdk openjdk bot closed this Jun 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@jbachorik Pushed as commit 684f12e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants