-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283849: AsyncGetCallTrace may crash JVM on guarantee #1148
Conversation
👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
d1249db
to
cf4694c
Compare
/label hotspot |
@jbachorik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jbachorik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 684f12e.
Your commit was automatically rebased without conflicts. |
@jbachorik Pushed as commit 684f12e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A fairly straightforward backport.
There are only two types of minor adjustments that had to be done:
thread.cpp/hpp
filesThread->as_java_thread()
function - can be exactly replicated by((JavaThread*)current_thread)
castProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1148/head:pull/1148
$ git checkout pull/1148
Update a local copy of the PR:
$ git checkout pull/1148
$ git pull https://git.openjdk.org/jdk11u-dev pull/1148/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1148
View PR using the GUI difftool:
$ git pr show -t 1148
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1148.diff