New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261160: Add a deserialization JFR event #1150
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! |
Going to push as commit 765c5b4.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.17-oracle.
It needed a row of adaptions, but none touching the base functionality.
src/java.base/share/classes/java/io/ObjectInputStream.java
Resolved an import. Trivial.
src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java
In this file some cleanup wrt alphabetic ordering was made that does
not apply to 11. (ProcessStartEvent not in 11.)
test/jdk/jdk/jfr/event/io/TestDeserializationEvent.java
I adapted this test to Java 11 syntax.
It used records and modern instanceof statements.
Also, I included /test/lib/jdk/test/lib/serial/SerialObjectBuilder.java
from "JDK-8254234: Add test library stream object builder".
In that file, I also removed the record and replaced
Class.descriptorString() by a local implementation. DescriptorString() was
introduced in 12. Backporting 8254234
as prerequisite makes no sense as the adapted test is not
in 11, thus the backport would be quite incomplete.
test/jdk/jdk/jfr/event/metadata/TestDefaultConfigurations.java
test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java
Resolved due to context (ProcessStartEvent not in 11.)
test/lib/jdk/test/lib/jfr/EventNames.java
Resolved due to context (DirectBufferStatistics not in 11.)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1150/head:pull/1150
$ git checkout pull/1150
Update a local copy of the PR:
$ git checkout pull/1150
$ git pull https://git.openjdk.org/jdk11u-dev pull/1150/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1150
View PR using the GUI difftool:
$ git pr show -t 1150
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1150.diff