Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8220744: [TESTBUG] Move RedefineTests from runtime to serviceability #1153

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 15, 2022

I backport this for parity with 11.0.17-oracle.

not moved because not in 11:
test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java
test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c
test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java

Resolved one Copyright.

Marking as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8220744: [TESTBUG] Move RedefineTests from runtime to serviceability

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1153/head:pull/1153
$ git checkout pull/1153

Update a local copy of the PR:
$ git checkout pull/1153
$ git pull https://git.openjdk.org/jdk11u-dev pull/1153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1153

View PR using the GUI difftool:
$ git pr show -t 1153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1153.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3ed98222a7c3410dead4b02123b562b332fac9aa 8220744: [TESTBUG] Move RedefineTests from runtime to serviceability Jun 15, 2022
@openjdk
Copy link

openjdk bot commented Jun 15, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 15, 2022

/clean

@openjdk openjdk bot added the clean label Jun 15, 2022
@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8220744: [TESTBUG] Move RedefineTests from runtime to serviceability

Move tests out of runtime to jvmti/RedefineClasses

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

Going to push as commit 674e717.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 9307c8c: 8217332: JTREG: Clean up, use generics instead of raw types
  • 9f059ee: 8213695: gc/TestAllocateHeapAtMultiple.java is slow in some configs
  • 1bdba34: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses
  • 87ba1ef: 8282538: PKCS11 tests fail on CentOS Stream 9
  • 4fbe635: 8251551: Use .md filename extension for README
  • 246f48e: 8212904: JTextArea line wrapping incorrect when using UI scale
  • 684f12e: 8283849: AsyncGetCallTrace may crash JVM on guarantee
  • 8e94c68: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ffd8dc2: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2022
@openjdk openjdk bot closed this Jun 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin Pushed as commit 674e717.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8220744 branch June 21, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant