8215291: Broken links when generating from project without modules

[basil]

Hi all,

This pull request contains a clean backport of JDK-8215291 (openjdk/jdk@cb55317).

The commit being backported was authored by @hns on December 21, 2018, and was reviewed by @jonathan-gibbons.

See JENKINS-68761 for the motivation behind this backport.

I tested this by reproducing the search problem described in JENKINS-68761 on jdk11u-dev and verified that I could no longer reproduce the problem after backporting this commit.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8215291: Broken links when generating from project without modules

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1157/head:pull/1157
$ git checkout pull/1157

Update a local copy of the PR:
$ git checkout pull/1157
$ git pull https://git.openjdk.org/jdk11u-dev pull/1157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1157

View PR using the GUI difftool:
$ git pr show -t 1157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1157.diff

[bridgekeeper]

👋 Welcome back basil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@basil This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8215291: Broken links when generating from project without modules

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• c53e0fe: 8288467: remove memory_operand assert for spilled instructions
• c6e2a5b: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
• 87bcc4e: 8284882: SIGSEGV in Node::verify_edges due to compilation bailout
• fb76f0e: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
• 6fe8d8d: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
• b4f0859: 8285398: Cache the results of constraint checks
• eb8789b: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
• 97178bf: 8282214: Upgrade JQuery to version 3.6.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (04cdcc5f)
• 00: Full (1f3dc900)

[basil]

I do not have JBS access. Can someone please submit the following comment with the jdk11u-fix-request label:

See JENKINS-68761 for the motivation behind this backport. I tested this by reproducing the search problem described in JENKINS-68761 on jdk11u-dev and verified that I could no longer reproduce the problem after backporting this commit. The commit applied cleanly with no conflicts.

[basil]

@TheRealMDoerr You've helped shepherd some of my previous backports to completion, for which I am grateful. Are you interested in shepherding this one to completion? I am not sure what else I need to do from my perspective to drive this forward.

[TheRealMDoerr]

Label and comment added. Please wait for the "jdk11u-fix-yes" label before using /integrate.

[basil]

/integrate

[openjdk]

@basil
Your change (at version 04cdcc5) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 732d9bc.
Since your change was applied there have been 8 commits pushed to the master branch:

• c53e0fe: 8288467: remove memory_operand assert for spilled instructions
• c6e2a5b: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
• 87bcc4e: 8284882: SIGSEGV in Node::verify_edges due to compilation bailout
• fb76f0e: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
• 6fe8d8d: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
• b4f0859: 8285398: Cache the results of constraint checks
• eb8789b: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
• 97178bf: 8282214: Upgrade JQuery to version 3.6.0

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @basil Pushed as commit 732d9bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[basil]

Thank you!