Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out #1159

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 20, 2022

I backport this for parity with 11.0.17-oracle.

test/hotspot/jtreg/gc/arguments/TestDisableDefaultGC.java
Trivial resolve.

test/hotspot/jtreg/gc/arguments/TestMaxRAMFlags.java omitted.
Test came with https://bugs.openjdk.org/browse/JDK-8224764 which is not in 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1159/head:pull/1159
$ git checkout pull/1159

Update a local copy of the PR:
$ git checkout pull/1159
$ git pull https://git.openjdk.org/jdk11u-dev pull/1159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1159

View PR using the GUI difftool:
$ git pr show -t 1159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1159.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b85ebc19e0c593595ee1ece211755ee2be19860f 8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, -XX:-UseShenandoahGC was added by JDK-8214259 in JDK12. Seems like it was not completely backported to 11u. LGTM.

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out

Disable ZapUnusedHeapArea and VerifyBeforeExit for gc/arguments tests.

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 22, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

Going to push as commit d12c2e2.
Since your change was applied there have been 17 commits pushed to the master branch:

  • c10e0de: 8272398: Update DockerTestUtils.buildJdkDockerImage()
  • 8242dd1: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
  • a2ecf87: 8281628: KeyAgreement : generateSecret intermittently not resetting
  • cb4e3fe: 8265100: (fs) WindowsFileStore.hashCode() should read cached hash code once
  • 97a472c: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
  • aa35f09: 8139348: Deprecate 3DES and RC4 in Kerberos
  • 765c5b4: 8261160: Add a deserialization JFR event
  • 661236d: 8236823: Ensure that API documentation uses minified libraries
  • 8c37d06: 8226976: SessionTimeOutTests uses == operator for String value check
  • 674e717: 8220744: [TESTBUG] Move RedefineTests from runtime to serviceability
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/8e94c68c294537cd1d188bc4d68019ae61d75c58...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2022
@openjdk openjdk bot closed this Jun 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@GoeLin Pushed as commit d12c2e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8217170 branch June 22, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants