-
Notifications
You must be signed in to change notification settings - Fork 253
8251551: Use .md filename extension for README #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean. Lgtm.
|
@gdams This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @RealCLanger) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
You now have to ask for integration permission by tagging the JBS issue with the "jdk11u-fix-request" label and a "Fix Request (11u)" comment. I'll sponsor. |
|
I've flagged approval, change looks correct. /sponsor |
|
@RealCLanger @gdams Pushed as commit 4fbe635. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
backports https://bugs.openjdk.org/browse/JDK-8251551 as it's a low risk change
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1161/head:pull/1161$ git checkout pull/1161Update a local copy of the PR:
$ git checkout pull/1161$ git pull https://git.openjdk.org/jdk11u-dev pull/1161/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1161View PR using the GUI difftool:
$ git pr show -t 1161Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1161.diff