Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251551: Use .md filename extension for README #1161

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jun 20, 2022

backports https://bugs.openjdk.org/browse/JDK-8251551 as it's a low risk change


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1161/head:pull/1161
$ git checkout pull/1161

Update a local copy of the PR:
$ git checkout pull/1161
$ git pull https://git.openjdk.org/jdk11u-dev pull/1161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1161

View PR using the GUI difftool:
$ git pr show -t 1161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1161.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6ed221cb9ad2e81d92dda0ef32095dda5d52cb85 8251551: Use .md filename extension for README Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251551: Use .md filename extension for README

Reviewed-by: phh, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 246f48e: 8212904: JTextArea line wrapping incorrect when using UI scale

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2022
@gdams
Copy link
Member Author

gdams commented Jun 20, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@gdams
Your change (at version b618bb2) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

You now have to ask for integration permission by tagging the JBS issue with the "jdk11u-fix-request" label and a "Fix Request (11u)" comment. I'll sponsor.

@RealCLanger
Copy link
Contributor

I've flagged approval, change looks correct.

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

Going to push as commit 4fbe635.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 246f48e: 8212904: JTextArea line wrapping incorrect when using UI scale

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2022
@openjdk openjdk bot closed this Jun 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@RealCLanger @gdams Pushed as commit 4fbe635.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the readme branch June 21, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants