Skip to content

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 20, 2022

Hi all,
This pull request contains a backport of commit ebfa27b9 from the openjdk/jdk repository.
The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1162/head:pull/1162
$ git checkout pull/1162

Update a local copy of the PR:
$ git checkout pull/1162
$ git pull https://git.openjdk.org/jdk11u-dev pull/1162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1162

View PR using the GUI difftool:
$ git pr show -t 1162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1162.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ebfa27b9f06aee8ceceabc564a78a351903ce9a1 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 237 new commits pushed to the master branch:

  • 0013d84: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS
  • b8bc720: 8282857: Create a regression test for JDK-4702690
  • f8e71f8: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
  • 905baaf: 8290451: Incorrect result when switching to C2 OSR compilation from C1
  • 49b85e8: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
  • fba01e8: 8290705: StringConcat::validate_mem_flow asserts with "unexpected user: StoreI"
  • 0f84f99: 8282276: Problem list failing two Robot Screen Capture tests
  • fb9a279: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
  • 66d4be3: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
  • ca33f6c: 8293578: Duplicate ldc generated by javac
  • ... and 227 more: https://git.openjdk.org/jdk11u-dev/compare/684f12e7fd0f939ccc133aec46ed3fb7d24d5cc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2022
@mrserb mrserb marked this pull request as ready for review June 20, 2022 21:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2022

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2022

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 15, 2022
@mrserb
Copy link
Member Author

mrserb commented Sep 8, 2022

/open

@openjdk openjdk bot reopened this Sep 8, 2022
@openjdk
Copy link

openjdk bot commented Sep 8, 2022

@mrserb This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2022

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Oct 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

Going to push as commit 87853b0.
Since your change was applied there have been 326 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2022
@openjdk openjdk bot closed this Oct 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@mrserb Pushed as commit 87853b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant