8288865: [aarch64] LDR instructions must use legitimized addresses

[apavlyutkin]

Hi!

Please review the fix to non-volatile memory access on aarch64 that makes LDR instructions to use legitimized addresses exactly like it was done to STR instruction by https://bugs.openjdk.org/browse/JDK-8235385.

Verification (18.04.6 LTS / aarch64):

test/hotspot/jtreg/compiler/unsafe/NonVolatileMemoryAccessWithLongOffset.java

passes 10 of 10 runs. At least a half of runs failed before the fix.

Regression (18.04.6 LTS / aarch64): hotspot_compiler

@theRealAph @sandlerwang could you look at that? Thank you

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288865: [aarch64] LDR instructions must use legitimized addresses

Reviewers

• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1164/head:pull/1164
$ git checkout pull/1164

Update a local copy of the PR:
$ git checkout pull/1164
$ git pull https://git.openjdk.org/jdk11u-dev pull/1164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1164

View PR using the GUI difftool:
$ git pr show -t 1164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1164.diff

[bridgekeeper]

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (0b639f34)

[apavlyutkin]

ping

[openjdk]

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8288865: [aarch64] LDR instructions must use legitimized addresses

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

• c1e2cf6: 8284758: [linux] improve print_container_info
• e568880: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
• 9e8917b: Merge
• edd32ef: 8272243: Improve DER parsing
• 07dd941: 8284370: Improve zlib usage
• 1327459: 8281866: Enhance MethodHandle invocations
• 13bf52c: 8285407: Improve Xalan supports
• 6bc1874: 8283190: Improve MIDI processing
• 6c0ba07: 8281859: Improve class compilation
• f7a521e: 8272249: Better properties of loaded Properties
• ... and 75 more: https://git.openjdk.org/jdk11u-dev/compare/4fbe635b21e3aba14dba760168a2f8965c7b29f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[apavlyutkin]

/integrate

[openjdk]

@apavlyutkin
Your change (at version 0b639f3) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 1f40289.
Since your change was applied there have been 85 commits pushed to the master branch:

• c1e2cf6: 8284758: [linux] improve print_container_info
• e568880: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
• 9e8917b: Merge
• edd32ef: 8272243: Improve DER parsing
• 07dd941: 8284370: Improve zlib usage
• 1327459: 8281866: Enhance MethodHandle invocations
• 13bf52c: 8285407: Improve Xalan supports
• 6bc1874: 8283190: Improve MIDI processing
• 6c0ba07: 8281859: Improve class compilation
• f7a521e: 8272249: Better properties of loaded Properties
• ... and 75 more: https://git.openjdk.org/jdk11u-dev/compare/4fbe635b21e3aba14dba760168a2f8965c7b29f5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @apavlyutkin Pushed as commit 1f40289.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.