Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288865: [aarch64] LDR instructions must use legitimized addresses #1164

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jun 21, 2022

Hi!

Please review the fix to non-volatile memory access on aarch64 that makes LDR instructions to use legitimized addresses exactly like it was done to STR instruction by https://bugs.openjdk.org/browse/JDK-8235385.

Verification (18.04.6 LTS / aarch64):

test/hotspot/jtreg/compiler/unsafe/NonVolatileMemoryAccessWithLongOffset.java

passes 10 of 10 runs. At least a half of runs failed before the fix.

Regression (18.04.6 LTS / aarch64): hotspot_compiler

@theRealAph @sandlerwang could you look at that? Thank you


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288865: [aarch64] LDR instructions must use legitimized addresses

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1164/head:pull/1164
$ git checkout pull/1164

Update a local copy of the PR:
$ git checkout pull/1164
$ git pull https://git.openjdk.org/jdk11u-dev pull/1164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1164

View PR using the GUI difftool:
$ git pr show -t 1164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1164.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Webrevs

@apavlyutkin
Copy link
Contributor Author

ping

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8288865: [aarch64] LDR instructions must use legitimized addresses

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2022
@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@apavlyutkin
Your change (at version 0b639f3) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented Jul 20, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

Going to push as commit 1f40289.
Since your change was applied there have been 85 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2022
@openjdk openjdk bot closed this Jul 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@yan-too @apavlyutkin Pushed as commit 1f40289.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants