Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253829: Wrong length compared in SSPI bridge #1170

Closed
wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Jun 22, 2022

I'd like to backport the fix for an obvious error as it occurs in the production of one of our customer


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1170/head:pull/1170
$ git checkout pull/1170

Update a local copy of the PR:
$ git checkout pull/1170
$ git pull https://git.openjdk.org/jdk11u-dev pull/1170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1170

View PR using the GUI difftool:
$ git pr show -t 1170

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1170.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e5ba020ee9212a61004cf41492fc96518139f7ae 8253829: Wrong length compared in SSPI bridge Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253829: Wrong length compared in SSPI bridge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8138382: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
  • 4945cfe: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption
  • d12c2e2: 8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

@snazarkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@snazarkin
Your change (at version 2e48a36) is now ready to be sponsored by a Committer.

@bae
Copy link

bae commented Jun 23, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 23, 2022

Going to push as commit e16aaca.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 1c1f7a1: 8210722: JAXP Tests: CatalogSupport2 and CatalogSupport3 generate incorrect messages upon failure
  • 8138382: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
  • 4945cfe: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption
  • d12c2e2: 8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2022
@openjdk openjdk bot closed this Jun 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@bae @snazarkin Pushed as commit e16aaca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants