Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private #1176

Closed
wants to merge 5 commits into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Jun 22, 2022

Trying to set up this PR to be dependent on #1129. Clean backport.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1176/head:pull/1176
$ git checkout pull/1176

Update a local copy of the PR:
$ git checkout pull/1176
$ git pull https://git.openjdk.org/jdk11u-dev pull/1176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1176

View PR using the GUI difftool:
$ git pr show -t 1176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1176.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into pr/1129 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@phohensee
Copy link
Member

/clean

Clean backport after #1129.

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@phohensee Can only mark backport pull requests, with an original hash, as clean

@phohensee
Copy link
Member

Pre-submit test failure looks unrelated.

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@caojoshua This pull request has not yet been marked as ready for integration.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@phohensee The change author (@caojoshua) must issue an integrate command before the integration can be sponsored.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1129 to master July 5, 2022 17:02
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8247964
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 5, 2022
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2022
@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 5, 2022
@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@caojoshua
Your change (at version d2304c7) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

Going to push as commit 7a076e4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2022
@openjdk openjdk bot closed this Jul 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 5, 2022
@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@phohensee @caojoshua Pushed as commit 7a076e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@caojoshua caojoshua deleted the 8247964 branch July 5, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants