-
Notifications
You must be signed in to change notification settings - Fork 241
8286582: Build fails on macos aarch64 when using --with-zlib=bundled #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
c54f990
to
c8fdb4d
Compare
@@ -869,7 +870,8 @@ ifeq ($(ENABLE_HEADLESS_ONLY), false) | |||
EXTRA_HEADER_DIRS := $(LIBSPLASHSCREEN_HEADER_DIRS), \ | |||
DISABLED_WARNINGS_gcc := sign-compare type-limits unused-result \ | |||
maybe-uninitialized shift-negative-value implicit-fallthrough, \ | |||
DISABLED_WARNINGS_clang := incompatible-pointer-types deprecated-declarations, \ | |||
DISABLED_WARNINGS_clang := incompatible-pointer-types deprecated-declarations \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/clean I manually fixed conflict in this line since the jdk11 has a different list of disabled warnings, also the dates in the copyrights are different.
/clean see comment above |
@mrserb This backport pull request is now marked as clean |
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8363d9d.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit 50d47de8 from the openjdk/jdk repository.
The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1177/head:pull/1177
$ git checkout pull/1177
Update a local copy of the PR:
$ git checkout pull/1177
$ git pull https://git.openjdk.org/jdk11u-dev pull/1177/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1177
View PR using the GUI difftool:
$ git pr show -t 1177
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1177.diff