Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference #118

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jul 9, 2021

Backporting to stabilize the test and for 11.0.13-oracle parity. Clean backport. Affected tests still passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/118/head:pull/118
$ git checkout pull/118

Update a local copy of the PR:
$ git checkout pull/118
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 118

View PR using the GUI difftool:
$ git pr show -t 118

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/118.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 9, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport d8355e0281e19cb2cf9fff070f3c7540de7bcb95 8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

This backport pull request has now been updated with issue and summary from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference

This fix upgrades java/nio/channels/DatagramChannel/ReceiveISA.java so it can handle interference from stray packets.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 9, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jul 11, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 11, 2021

Going to push as commit 3869a19.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 2c49cca: 8240555: Using env of JAVA_TOOL_OPTIONS and _JAVA_OPTIONS breaks QuietOption.java test
  • 3ce8c72: 8268635: Corrupt oop in ClassLoaderData
  • 7bc4f40: 8261238: NMT should not limit baselining by size threshold
  • 591d769: 8263407: SPARC64 detection fails on Athena (SPARC64-X)
  • 509170c: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 11, 2021

@shipilev Pushed as commit 3869a19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8249773 branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant