-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null #1182
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@@ -159,6 +159,9 @@ public final boolean permits(Set<CryptoPrimitive> primitives, | |||
if (!cachedCheckAlgorithm(algorithm)) { | |||
return false; | |||
} | |||
if (algorithm == null || algorithm.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check for null algorithm needs to happen before cachedCheckAlgorithm
is called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks for catching this!
Implementing Daniels comments. Thanks for catching this!
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8285696
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 6fe8d8d. |
I backport this for parity with 11.0.17-oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1182/head:pull/1182
$ git checkout pull/1182
Update a local copy of the PR:
$ git checkout pull/1182
$ git pull https://git.openjdk.org/jdk11u-dev pull/1182/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1182
View PR using the GUI difftool:
$ git pr show -t 1182
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1182.diff