Skip to content

8288467: remove memory_operand assert for spilled instructions #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 27, 2022

I backport this for parity with 11.0.17-oracle

I had to do a trivial resolve.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288467: remove memory_operand assert for spilled instructions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1188/head:pull/1188
$ git checkout pull/1188

Update a local copy of the PR:
$ git checkout pull/1188
$ git pull https://git.openjdk.org/jdk11u-dev pull/1188/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1188

View PR using the GUI difftool:
$ git pr show -t 1188

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1188.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the base branch from master to pr/1185 June 27, 2022 06:29
@GoeLin GoeLin changed the title Goetz backport 8288467 Backport af05139133530871c88991aa0340205cfc44972a Jun 27, 2022
@openjdk openjdk bot changed the title Backport af05139133530871c88991aa0340205cfc44972a 8288467: remove memory_operand assert for spilled instructions Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GoeLin
Copy link
Member Author

GoeLin commented Jun 27, 2022

Pre-submit failure: macos
com/sun/jdi/AfterThreadDeathTest.java
FAILED: Did not get expected IllegalThreadStateExceptio

A failure I have not seen before, but surely unrelated.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1185 to master June 29, 2022 13:27
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8288467
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8288467: remove memory_operand assert for spilled instructions

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2022
@GoeLin GoeLin force-pushed the goetz_backport_8288467 branch from 1aca6dd to dc2a09f Compare June 29, 2022 13:45
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 29, 2022

/integrate

@openjdk-notifier
Copy link

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

Going to push as commit c53e0fe.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 29, 2022
@openjdk openjdk bot closed this Jun 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@GoeLin Pushed as commit c53e0fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8288467 branch June 29, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants