8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend

[reinrich]

Hi all,

This pull request contains a backport of commit ca2efb73 from the openjdk/jdk repository.

The commit being backported was authored by Richard Reingruber on 15 Nov 2021 and was reviewed by Chris Plummer, Serguei Spitsyn and Ralf Schmelter.

The commit applied cleanly except for one minor conflict because of the comments on the declarations of current_ei and pendingStop not present in jdk11.
Also I had to backport the changes on TestScaffold from JDK-8255381 (09e8675f)

The backport passed our CI testing. This includes most JCK and JTREG tiers 1-4, also in Xcomp mode, on the standard platforms and also on ppc64le and s390x.

Thanks!
Richard.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1189/head:pull/1189
$ git checkout pull/1189

Update a local copy of the PR:
$ git checkout pull/1189
$ git pull https://git.openjdk.org/jdk11u-dev pull/1189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1189

View PR using the GUI difftool:
$ git pr show -t 1189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1189.diff

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 8b56027: 8193462: Fix Filer handling of package-info initial elements
• a27448e: 8266675: Optimize IntHashTable for encapsulation and ease of use
• bfc5746: 8203277: preflow visitor used during lambda attribution shouldn't visit class definitions inside the lambda body
• 65ac123: 8254178: Remove .hgignore
• 6d56b2b: 8289799: Build warning in methodData.cpp memset zero-length parameter
• 4f1ac63: 8279622: C2: miscompilation of map pattern as a vector reduction
• 1e7ff48: 8289477: Memory corruption with CPU_ALLOC, CPU_FREE on muslc
• 7a076e4: 8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private
• 290a7e3: 8247907: XMLDsig logging does not work
• 3a0013f: 8219074: [TESTBUG] runtime/containers/docker/TestCPUAwareness.java typo of printing parameters (period should be shares)
• ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/c53e0fe3f1a4943cc271cad3d11bd7fa4b81a496...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (bd31af77)
• 00: Full (ef2fabac)

[reinrich]

Need to backport test lib enhancements from JDK-8255381 first

[TheRealMDoerr]

Thanks for the detailed description. 1st commit is basically clean and I had already reviewed the part of JDK-8255381. LGTM.

[reinrich]

Thanks for reviewing!

/integrate

[openjdk]

Going to push as commit e568880.
Since your change was applied there have been 47 commits pushed to the master branch:

• 9e8917b: Merge
• edd32ef: 8272243: Improve DER parsing
• 07dd941: 8284370: Improve zlib usage
• 1327459: 8281866: Enhance MethodHandle invocations
• 13bf52c: 8285407: Improve Xalan supports
• 6bc1874: 8283190: Improve MIDI processing
• 6c0ba07: 8281859: Improve class compilation
• f7a521e: 8272249: Better properties of loaded Properties
• de08dc4: 8277608: Address IP Addressing
• e2fa856: 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout
• ... and 37 more: https://git.openjdk.org/jdk11u-dev/compare/c53e0fe3f1a4943cc271cad3d11bd7fa4b81a496...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit e568880.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.