-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278067: Make HttpURLConnection default keep alive timeout configurable #1193
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This backport seems to miss the changes from src/java.base/share/classes/java/net/doc-files/net-properties.html in the original commit.
assertTrue(msg != null && msg.contains("Network is unreachable")); | ||
assertNotNull(msg); | ||
assertTrue(msg.contains("Network is unreachable") | ||
|| msg.contains("No route to host")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here? This is not part of the original commit, or?
They sneaked in from another backport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Pre-submit failure: SuspendAtExit.java known to be failing, unrelated. |
/integrate |
Going to push as commit c9a7259.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.17-oracle.
I had to resolve KeepAliveCache because the indentation differs.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1193/head:pull/1193
$ git checkout pull/1193
Update a local copy of the PR:
$ git checkout pull/1193
$ git pull https://git.openjdk.org/jdk11u-dev pull/1193/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1193
View PR using the GUI difftool:
$ git pr show -t 1193
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1193.diff