Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278067: Make HttpURLConnection default keep alive timeout configurable #1193

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 1, 2022

I backport this for parity with 11.0.17-oracle.

I had to resolve KeepAliveCache because the indentation differs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8278067: Make HttpURLConnection default keep alive timeout configurable
  • JDK-8288978: Make HttpURLConnection default keep alive timeout configurable (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1193/head:pull/1193
$ git checkout pull/1193

Update a local copy of the PR:
$ git checkout pull/1193
$ git pull https://git.openjdk.org/jdk11u-dev pull/1193/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1193

View PR using the GUI difftool:
$ git pr show -t 1193

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1193.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d8f44aa39e921594505864e6270f42b745265293 8278067: Make HttpURLConnection default keep alive timeout configurable Jul 1, 2022
@openjdk
Copy link

openjdk bot commented Jul 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 1, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport seems to miss the changes from src/java.base/share/classes/java/net/doc-files/net-properties.html in the original commit.

assertTrue(msg != null && msg.contains("Network is unreachable"));
assertNotNull(msg);
assertTrue(msg.contains("Network is unreachable")
|| msg.contains("No route to host"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here? This is not part of the original commit, or?

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278067: Make HttpURLConnection default keep alive timeout configurable

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 6ecce29: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run
  • 9b73adb: 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090
  • bf08f88: 8270090: C2: LCM may prioritize CheckCastPP nodes over projections
  • 732d9bc: 8215291: Broken links when generating from project without modules
  • c53e0fe: 8288467: remove memory_operand assert for spilled instructions
  • c6e2a5b: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
  • 87bcc4e: 8284882: SIGSEGV in Node::verify_edges due to compilation bailout
  • fb76f0e: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • 6fe8d8d: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
  • b4f0859: 8285398: Cache the results of constraint checks
  • ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/8363d9db801314f13e708db62993da5b73634f69...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 4, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jul 5, 2022

Pre-submit failure: SuspendAtExit.java known to be failing, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Jul 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

Going to push as commit c9a7259.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2022
@openjdk openjdk bot closed this Jul 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2022
@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@GoeLin Pushed as commit c9a7259.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants