-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8281181: Do not use CPU Shares to compute active processor count #1196
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go. File src/hotspot/os/linux/cgroupSubsystem_linux.cpp
is missing the copyright year update from the original patch and a tiny nit below.
@@ -201,13 +218,15 @@ private static void testAPCCombo(String cpuset, int quota, int period, int share | |||
.addDockerOpts("--cpu-quota=" + quota) | |||
.addDockerOpts("--cpu-shares=" + shares); | |||
|
|||
if (useContainerCpuShares) opts.addJavaOpts("-XX:+UseContainerCpuShares"); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Thanks Severin for the remarks. I added the copyright year and the test output line, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 32babc1.
Your commit was automatically rebased without conflicts. |
jdk11u-dev backport of 8281181, copyright headers needed adjustment and minor diffs in strides
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1196/head:pull/1196
$ git checkout pull/1196
Update a local copy of the PR:
$ git checkout pull/1196
$ git pull https://git.openjdk.org/jdk11u-dev pull/1196/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1196
View PR using the GUI difftool:
$ git pr show -t 1196
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1196.diff