Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266642: Improve ResolvedMethodTable hash function #12

Closed
wants to merge 1 commit into from

Conversation

D-D-H
Copy link

@D-D-H D-D-H commented Jun 3, 2021

This is a backport of 8266642.

Fix request for 11u approved here: https://bugs.openjdk.java.net/browse/JDK-8266642


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266642: Improve ResolvedMethodTable hash function

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/12.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 3, 2021

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2021

Webrevs

@D-D-H
Copy link
Author

@D-D-H D-D-H commented Jun 4, 2021

/label add backport

@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@D-D-H The label backport is not a valid label. These labels are valid:

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 4, 2021

Hi, @D-D-H. Your PR is not recognized as a backport by the bots because the commit message does not match the expected format, as per https://wiki.openjdk.java.net/display/SKARA/Backports#Backports-CLI

It should be 'Backport 83b3607'. You can change it via 'git commit --amend' and then force push the branch.

@D-D-H
Copy link
Author

@D-D-H D-D-H commented Jun 4, 2021

Hi, @D-D-H. Your PR is not recognized as a backport by the bots because the commit message does not match the expected format, as per https://wiki.openjdk.java.net/display/SKARA/Backports#Backports-CLI

It should be 'Backport 83b3607'. You can change it via 'git commit --amend' and then force push the branch.

Done, thank you!

@D-D-H D-D-H changed the title 8266642: improve ResolvedMethodTable hash function Backport 83b360729060abaefb00a0b3f6165926db956bf8 Jun 4, 2021
@openjdk openjdk bot changed the title Backport 83b360729060abaefb00a0b3f6165926db956bf8 8266642: Improve ResolvedMethodTable hash function Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@D-D-H This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266642: Improve ResolvedMethodTable hash function

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 5c35022: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
  • 006979a: 8257148: Remove obsolete code in AWTView.m
  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86
  • 09d3082: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 4, 2021
@D-D-H
Copy link
Author

@D-D-H D-D-H commented Jun 4, 2021

@RealCLanger
Please help sponsor it when you have time.

Best,
Denghui

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 4, 2021

@RealCLanger
Please help sponsor it when you have time.

Best,
Denghui

Sure, you'll however need to /integrate first.

@D-D-H
Copy link
Author

@D-D-H D-D-H commented Jun 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@D-D-H
Your change (at version 449769d) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 4, 2021

/sponsor

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@RealCLanger @D-D-H Since your change was applied there have been 5 commits pushed to the master branch:

  • 5c35022: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
  • 006979a: 8257148: Remove obsolete code in AWTView.m
  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86
  • 09d3082: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Your commit was automatically rebased without conflicts.

Pushed as commit e6d0e9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants