Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289799: Build warning in methodData.cpp memset zero-length parameter #1204

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jul 7, 2022

Trival clean backport, prevents gcc warnings on Fedora 12 GCC 8.3

The commit being backported was authored by Thomas Stuefe on 7 Jul 2022 and was reviewed by Jie Fu and Lutz Schmidt.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289799: Build warning in methodData.cpp memset zero-length parameter

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1204/head:pull/1204
$ git checkout pull/1204

Update a local copy of the PR:
$ git checkout pull/1204
$ git pull https://git.openjdk.org/jdk11u-dev pull/1204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1204

View PR using the GUI difftool:
$ git pr show -t 1204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1204.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cce77a700141a854bafaa5ccb33db026affcf322 8289799: Build warning in methodData.cpp memset zero-length parameter Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289799: Build warning in methodData.cpp memset zero-length parameter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2022

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Jul 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2022

Going to push as commit 6d56b2b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4f1ac63: 8279622: C2: miscompilation of map pattern as a vector reduction

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2022
@openjdk openjdk bot closed this Jul 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2022
@openjdk
Copy link

openjdk bot commented Jul 8, 2022

@tstuefe Pushed as commit 6d56b2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant