-
Notifications
You must be signed in to change notification settings - Fork 238
8193462: Fix Filer handling of package-info initial elements #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back gli! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@lgxbslgx This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport has been approved. Could I get your help to sponsor it? Integrating. /integrate |
/sponsor |
Going to push as commit 8b56027.
Your commit was automatically rebased without conflicts. |
@RealCLanger @lgxbslgx Pushed as commit 8b56027. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
In order to backport JDK-8255729 [1] cleanly to jdk11, I need to backport this patch [2] firstly.
The code applies cleanly.
[1] https://bugs.openjdk.org/browse/JDK-8255729
[2] https://bugs.openjdk.org/browse/JDK-8193462
Best Regards,
-- Guoxiong
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1208/head:pull/1208
$ git checkout pull/1208
Update a local copy of the PR:
$ git checkout pull/1208
$ git pull https://git.openjdk.org/jdk11u-dev pull/1208/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1208
View PR using the GUI difftool:
$ git pr show -t 1208
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1208.diff