Skip to content

8193462: Fix Filer handling of package-info initial elements #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Jul 10, 2022

Hi all,

In order to backport JDK-8255729 [1] cleanly to jdk11, I need to backport this patch [2] firstly.

The code applies cleanly.

[1] https://bugs.openjdk.org/browse/JDK-8255729
[2] https://bugs.openjdk.org/browse/JDK-8193462

Best Regards,
-- Guoxiong


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8193462: Fix Filer handling of package-info initial elements

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1208/head:pull/1208
$ git checkout pull/1208

Update a local copy of the PR:
$ git checkout pull/1208
$ git pull https://git.openjdk.org/jdk11u-dev pull/1208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1208

View PR using the GUI difftool:
$ git pr show -t 1208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1208.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2022

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fafd1b7536e9bd949f3a2f31da5679348e72c3cb 8193462: Fix Filer handling of package-info initial elements Jul 10, 2022
@openjdk
Copy link

openjdk bot commented Jul 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 10, 2022

@lgxbslgx This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8193462: Fix Filer handling of package-info initial elements

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 65ac123: 8254178: Remove .hgignore

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2022

Webrevs

@lgxbslgx
Copy link
Member Author

This backport has been approved. Could I get your help to sponsor it? Integrating.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@lgxbslgx
Your change (at version 22a9a28) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

Going to push as commit 8b56027.
Since your change was applied there have been 3 commits pushed to the master branch:

  • a27448e: 8266675: Optimize IntHashTable for encapsulation and ease of use
  • bfc5746: 8203277: preflow visitor used during lambda attribution shouldn't visit class definitions inside the lambda body
  • 65ac123: 8254178: Remove .hgignore

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2022
@openjdk openjdk bot closed this Jul 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@RealCLanger @lgxbslgx Pushed as commit 8b56027.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants