Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254318: Remove .hgtags #1211

Closed
wants to merge 1 commit into from
Closed

8254318: Remove .hgtags #1211

wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 11, 2022

backports https://bugs.openjdk.org/browse/JDK-8254318 as it's a low-risk change


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1211/head:pull/1211
$ git checkout pull/1211

Update a local copy of the PR:
$ git checkout pull/1211
$ git pull https://git.openjdk.org/jdk11u-dev pull/1211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1211

View PR using the GUI difftool:
$ git pr show -t 1211

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1211.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 62a7f5d3236ab2248518a475b1d8b71cb4bf1313 8254318: Remove .hgtags Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2022

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I also added JBS Request on your behalf and approved it.

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254318: Remove .hgtags

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8b56027: 8193462: Fix Filer handling of package-info initial elements
  • a27448e: 8266675: Optimize IntHashTable for encapsulation and ease of use
  • bfc5746: 8203277: preflow visitor used during lambda attribution shouldn't visit class definitions inside the lambda body

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 11, 2022
@gdams
Copy link
Member Author

gdams commented Jul 11, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@gdams
Your change (at version 8c2423f) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

Going to push as commit ab4a3e6.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 8b56027: 8193462: Fix Filer handling of package-info initial elements
  • a27448e: 8266675: Optimize IntHashTable for encapsulation and ease of use
  • bfc5746: 8203277: preflow visitor used during lambda attribution shouldn't visit class definitions inside the lambda body

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2022
@openjdk openjdk bot closed this Jul 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2022
@gdams gdams deleted the hgtags branch July 12, 2022 08:04
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@RealCLanger @gdams Pushed as commit ab4a3e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants