Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux #1217

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented Jul 12, 2022

Backport JDK-8262085

Clean backport except Copyright year


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1217/head:pull/1217
$ git checkout pull/1217

Update a local copy of the PR:
$ git checkout pull/1217
$ git pull https://git.openjdk.org/jdk11u-dev pull/1217/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1217

View PR using the GUI difftool:
$ git pr show -t 1217

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1217.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2022

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c569f1d64b3fbe1c5e98bfe73231123ffee18ef9 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 12, 2022
@takiguc
Copy link
Author

takiguc commented Jul 12, 2022

/clean

@openjdk openjdk bot added the clean label Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@takiguc This backport pull request is now marked as clean

@mlbridge
Copy link

mlbridge bot commented Jul 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@takiguc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • ab4a3e6: 8254318: Remove .hgtags
  • 8b56027: 8193462: Fix Filer handling of package-info initial elements
  • a27448e: 8266675: Optimize IntHashTable for encapsulation and ease of use
  • bfc5746: 8203277: preflow visitor used during lambda attribution shouldn't visit class definitions inside the lambda body
  • 65ac123: 8254178: Remove .hgignore

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2022
@takiguc
Copy link
Author

takiguc commented Jul 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

Going to push as commit c63209b.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk bot closed this Jul 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2022
@takiguc
Copy link
Author

takiguc commented Jul 19, 2022

jdk11u-fix-yes was confirmed

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@takiguc Pushed as commit c63209b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant