-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290198: Shenandoah: a few Shenandoah tests failure after JDK-8214799 11u backport #1220
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks, @rkennke |
Thanks for fixing this. |
/integrate |
@zhengyu123 Pushed as commit 9d0b5e5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this patch that fixes Shenandoah test failures after JDK-8214799 11u backport.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1220/head:pull/1220
$ git checkout pull/1220
Update a local copy of the PR:
$ git checkout pull/1220
$ git pull https://git.openjdk.org/jdk11u-dev pull/1220/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1220
View PR using the GUI difftool:
$ git pr show -t 1220
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1220.diff