Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290198: Shenandoah: a few Shenandoah tests failure after JDK-8214799 11u backport #1220

Closed
wants to merge 1 commit into from
Closed

8290198: Shenandoah: a few Shenandoah tests failure after JDK-8214799 11u backport #1220

wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jul 12, 2022

Please review this patch that fixes Shenandoah test failures after JDK-8214799 11u backport.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290198: Shenandoah: a few Shenandoah tests failure after JDK-8214799 11u backport

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1220/head:pull/1220
$ git checkout pull/1220

Update a local copy of the PR:
$ git checkout pull/1220
$ git pull https://git.openjdk.org/jdk11u-dev pull/1220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1220

View PR using the GUI difftool:
$ git pr show -t 1220

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1220.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2022

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290198: Shenandoah: a few Shenandoah tests failure after JDK-8214799 11u backport

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c9a7259: 8278067: Make HttpURLConnection default keep alive timeout configurable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2022
@zhengyu123
Copy link
Contributor Author

Thanks, @rkennke

@GoeLin
Copy link
Member

GoeLin commented Jul 14, 2022

Thanks for fixing this.

@zhengyu123
Copy link
Contributor Author

Thanks, @rkennke and @GoeLin

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

Going to push as commit 9d0b5e5.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c9a7259: 8278067: Make HttpURLConnection default keep alive timeout configurable

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2022
@openjdk openjdk bot closed this Jul 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@zhengyu123 Pushed as commit 9d0b5e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants