Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264208: Console charset API #1226

wants to merge 1 commit into from


Copy link

@calderast calderast commented Jul 14, 2022

Backport of JDK-8264208.

Along with JDK-8238203 and JDK-8266774, prerequisite for a clean backport of JDK-8272352 to allow java to correctly parse Chinese characters in file paths and string arguments passed to java.exe.

Applies cleanly except for year changes in copyright headers.


  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1225 must be integrated first



Using git

Checkout this PR locally:
$ git fetch pull/1226/head:pull/1226
$ git checkout pull/1226

Update a local copy of the PR:
$ git checkout pull/1226
$ git pull pull/1226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1226

View PR using the GUI difftool:
$ git pr show -t 1226

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Jul 14, 2022

👋 Welcome back calderast! A progress list of the required criteria for merging this PR into pr/1225 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bebfae48e3f1643f2456d680d170dcc22f7231bf 8264208: Console charset API Jul 14, 2022
Copy link

openjdk bot commented Jul 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 14, 2022
Copy link

mlbridge bot commented Jul 14, 2022


Copy link

/label add core-libs

Copy link

openjdk bot commented Jul 15, 2022

The label core-libs is not a valid label.
These labels are valid:

Copy link

This is an API change and not appropriate to back port to 11u.

@calderast calderast closed this Jul 15, 2022
Copy link

Closing, will not backport the Console Charset API

@calderast calderast deleted the jdk-8264208 branch July 16, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
backport rfr Pull request is ready for review
2 participants