-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas #123
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 23918db.
Your commit was automatically rebased without conflicts. |
This backport has the regression test for #120. It fails without that patch and passes after. I intend to integrate those two together. Patch didn't apply clean due to differences in the same code location, but the patch itself is the same as for JDK 18.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/123/head:pull/123
$ git checkout pull/123
Update a local copy of the PR:
$ git checkout pull/123
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/123/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 123
View PR using the GUI difftool:
$ git pr show -t 123
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/123.diff