Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas #123

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jul 12, 2021

This backport has the regression test for #120. It fails without that patch and passes after. I intend to integrate those two together. Patch didn't apply clean due to differences in the same code location, but the patch itself is the same as for JDK 18.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/123/head:pull/123
$ git checkout pull/123

Update a local copy of the PR:
$ git checkout pull/123
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 123

View PR using the GUI difftool:
$ git pr show -t 123

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/123.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6a9bc108736522897f03a75c83e90e2c2a183d27 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 09c6af3: 8249899: jdk/javadoc/tool/InlineTagsWithBraces.java uses @ignore w/o bug-id
  • 22a4752: 8268360: Missing check for infinite loop during node placement

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jul 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Jul 13, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

Going to push as commit 23918db.
Since your change was applied there have been 5 commits pushed to the master branch:

  • d4e4828: 8270196: [11u] [JVMCI] JavaType.toJavaName() returns incorrect type name for lambdas
  • 8d1e402: 8265132: C2 compilation fails with assert "missing precedence edge"
  • cbd3b0f: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion
  • 09c6af3: 8249899: jdk/javadoc/tool/InlineTagsWithBraces.java uses @ignore w/o bug-id
  • 22a4752: 8268360: Missing check for infinite loop during node placement

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@jerboaa Pushed as commit 23918db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant