Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265132: C2 compilation fails with assert "missing precedence edge" #124

Closed

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 12, 2021

Almost clean backport of JDK-8265132. Only a small hunk in block.hpp had to get inserted manually due to an unrelated context difference. Test fails in 11u without the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265132: C2 compilation fails with assert "missing precedence edge"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/124/head:pull/124
$ git checkout pull/124

Update a local copy of the PR:
$ git checkout pull/124
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/124/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 124

View PR using the GUI difftool:
$ git pr show -t 124

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/124.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 5644c4f942d9280ecc2dd3fdcd1680db6621da27 8265132: C2 compilation fails with assert "missing precedence edge" Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265132: C2 compilation fails with assert "missing precedence edge"

Reviewed-by: roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

Loading

Copy link
Contributor

@rwestrel rwestrel left a comment

Looks good to me.

Loading

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Jul 13, 2021

Thanks for the review!
/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

Going to push as commit 8d1e402.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cbd3b0f: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@TheRealMDoerr Pushed as commit 8d1e402.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@TheRealMDoerr TheRealMDoerr deleted the 8265132_C2_preg_edge branch Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants