-
Notifications
You must be signed in to change notification settings - Fork 253
8265132: C2 compilation fails with assert "missing precedence edge" #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
rwestrel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Thanks for the review! |
|
@TheRealMDoerr Pushed as commit 8d1e402. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Almost clean backport of JDK-8265132. Only a small hunk in block.hpp had to get inserted manually due to an unrelated context difference. Test fails in 11u without the fix.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/124/head:pull/124$ git checkout pull/124Update a local copy of the PR:
$ git checkout pull/124$ git pull https://git.openjdk.java.net/jdk11u-dev pull/124/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 124View PR using the GUI difftool:
$ git pr show -t 124Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/124.diff