-
Notifications
You must be signed in to change notification settings - Fork 238
8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List<byte[]>, List<byte[]>) #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@gdams This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@GoeLin please can you sponsor? |
/sponsor |
Going to push as commit 533a4e6.
Your commit was automatically rebased without conflicts. |
Backport required to bump JDK11u to jtreg 6
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1253/head:pull/1253
$ git checkout pull/1253
Update a local copy of the PR:
$ git checkout pull/1253
$ git pull https://git.openjdk.org/jdk11u-dev pull/1253/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1253
View PR using the GUI difftool:
$ git pr show -t 1253
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1253.diff