Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names #1257

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 21, 2022

I backport this for parity with 11.0.17-oracle.
Clean except for Copyright. Will mark /clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1257/head:pull/1257
$ git checkout pull/1257

Update a local copy of the PR:
$ git checkout pull/1257
$ git pull https://git.openjdk.org/jdk11u-dev pull/1257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1257

View PR using the GUI difftool:
$ git pr show -t 1257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1257.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0c9f8e472f1d452e97b3cbd50b9e5d700fffcd15 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 21, 2022

/clean

@openjdk openjdk bot added the clean label Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jul 23, 2022

Pre-submit failure: TestMemoryInitializationWithCMS.java, CMS tests known to be failing on 32-bit. Unrelated

@GoeLin
Copy link
Member Author

GoeLin commented Jul 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

Going to push as commit 20a5c40.
Since your change was applied there have been 4 commits pushed to the master branch:

  • d17924f: 8235870: C2 crashes in IdealLoopTree::est_loop_flow_merge_sz()
  • 0b54c61: 8266461: tools/jmod/hashes/HashesTest.java fails: static @test methods
  • 1a66d5a: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • 5a1377d: 8290813: jdk/nashorn/api/scripting/test/ScriptObjectMirrorTest.java fails: assertEquals is ambiguous

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2022
@openjdk openjdk bot closed this Jul 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@GoeLin Pushed as commit 20a5c40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8186143 branch July 25, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant