New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8239379: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java on OSX #1268
8239379: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java on OSX #1268
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8271512 |
@RealCLanger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit a625058.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit a625058. |
This is a preparation backport for the backport of JDK-8238268.
It backports JDK-8239379 and
JDK-8271512 which exclude
test serviceability/sa/sadebugd/DebugdConnectTest.java on both Mac OS architectures.
This test will generally be enabled via JDK-8238268.
While editing the test list, I also figured out that the backport of
JDK-8163805 was incomplete in that it
did not remove the exclusion of serviceability/sa/sadebugd/SADebugDTest.java which
I'm correcting in this patch as well.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1268/head:pull/1268
$ git checkout pull/1268
Update a local copy of the PR:
$ git checkout pull/1268
$ git pull https://git.openjdk.org/jdk11u-dev pull/1268/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1268
View PR using the GUI difftool:
$ git pr show -t 1268
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1268.diff