8215624: Add parallel heap iteration for jmap –histo #127

buddyliao · 2021-07-13T09:50:45Z

Unclean backport, since original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed.

8215624: Add parallel heap iteration for jmap -histo
8253763: ParallelObjectIterator should have virtual destructor

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issues

JDK-8215624: Add parallel heap iteration for jmap –histo
JDK-8253763: ParallelObjectIterator should have virtual destructor

Reviewers

Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/127/head:pull/127
$ git checkout pull/127

Update a local copy of the PR:
$ git checkout pull/127
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 127

View PR using the GUI difftool:
$ git pr show -t 127

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/127.diff

8215624: Add parallel heap iteration for jmap histo 8253763: ParallelObjectIterator should have virtual destructor

bridgekeeper · 2021-07-13T09:52:15Z

👋 Welcome back buddyliao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

buddyliao · 2021-07-13T09:55:33Z

/backport

openjdk · 2021-07-13T09:56:02Z

@buddyliao Unknown command backport - for a list of valid commands use /help.

mlbridge · 2021-07-13T10:02:14Z

Webrevs

01: Full - Incremental (d220790f)
00: Full (a2fe90d3)

openjdk · 2021-07-14T06:50:50Z

This backport pull request has now been updated with issue and summary from the original commit.

buddyliao · 2021-08-17T07:47:33Z

Would anyone help me to review this backport? Thank you!

RealCLanger · 2021-08-23T21:39:34Z

Hi, @buddyliao, we can have a look.

First of all, I see that you have included JDK-8253763 in this commit, which seems to make sense. Can you please add the issue to this PR via the "/issue add" command?

Furthermore, JDK-8251570 seems to be a follow up. Do you plan to backport this as well? If so, you could use a "dependent PR" to also propose a backport for this and we can test it together. Please let me know and I can guide you on how to do it.

RealCLanger · 2021-08-23T21:42:00Z

Another thing: Could you please enable Github Actions for this PR by merging jdk11u-dev master?

buddyliao · 2021-08-24T01:24:31Z

/issue add

openjdk · 2021-08-24T01:24:52Z

@buddyliao Command syntax:

/issue [add|remove] <id>[,<id>,...]
/issue [add] <id>: <description>
`/issue create [PX] /[subcomponent]

Some examples:

/issue add JDK-1234567,4567890
/issue remove JDK-4567890
/issue 1234567: Use this exact title
`/issue create hotspot/jfr
`/issue create P4 core-libs/java.nio

If issues are specified only by their ID, the title will be automatically retrieved from JBS. The project prefix (JDK- in the above examples) is optional. Separate multiple issue IDs using either spaces or commas.

buddyliao · 2021-08-24T01:25:18Z

/issue add JDK-8251570

openjdk · 2021-08-24T01:25:51Z

@buddyliao
Adding additional issue to issue list: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id.

buddyliao · 2021-08-24T01:30:27Z

Hi, @buddyliao, we can have a look.

First of all, I see that you have included JDK-8253763 in this commit, which seems to make sense. Can you please add the issue to this PR via the "/issue add" command?

Furthermore, JDK-8251570 seems to be a follow up. Do you plan to backport this as well? If so, you could use a "dependent PR" to also propose a backport for this and we can test it together. Please let me know and I can guide you on how to do it.

Hi RealCLanger , thank you for your kindly review and suggestions. I intent to backport JDK-8251570 after this patch. But I really don't know how to do it by using "dependent PR", since JDK-8251570 is based on this patch. Would you please guide me how to do this ? Thank you!

RealCLanger · 2021-08-24T07:22:02Z

Hi RealCLanger , thank you for your kindly review and suggestions. I intent to backport JDK-8251570 after this patch. But I really don't know how to do it by using "dependent PR", since JDK-8251570 is based on this patch. Would you please guide me how to do this ? Thank you!

Sure. It is as simple as to do the backport based on this change/branch and create a PR with branch pr/127 as target. If you have created the PR for JDK-8251570, please let me know. We can then run it together through our testing.

buddyliao · 2021-08-24T12:01:22Z

/issue add JDK-8253763

buddyliao · 2021-08-24T12:01:36Z

/issue remove JDK-8251570

openjdk · 2021-08-24T12:02:50Z

@buddyliao
Adding additional issue to issue list: 8253763: ParallelObjectIterator should have virtual destructor.

openjdk · 2021-08-24T12:04:09Z

@buddyliao
Removing additional issue from issue list: 8251570.

buddyliao · 2021-08-25T01:09:27Z

Hi RealCLanger , thank you for your kindly review and suggestions. I intent to backport JDK-8251570 after this patch. But I really don't know how to do it by using "dependent PR", since JDK-8251570 is based on this patch. Would you please guide me how to do this ? Thank you!

Sure. It is as simple as to do the backport based on this change/branch and create a PR with branch pr/127 as target. If you have created the PR for JDK-8251570, please let me know. We can then run it together through our testing.

Hi @RealCLanger, JDK-8251570 has been backported in #284, would you please help me to review them together, thank you very much.

RealCLanger · 2021-08-27T20:53:03Z

I've added both backports to our regression test queue now. Will try to review the changes some time next week.

schmelter-sap

Thanks for the downport. The changes look good to me.

openjdk · 2021-09-07T21:44:22Z

@buddyliao This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8215624: Add parallel heap iteration for jmap –histo
8253763: ParallelObjectIterator should have virtual destructor

Chunk and parallelize the heap scan

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
569688f: 8272316: Wrong Boot JDK help message in 11
1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
2908bbd: 8270216: [macOS] Update named used for Java run loop mode
ea1a1d8: 8251377: [macos11] JTabbedPane selected tab text is barely legible
9a5ba0b: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead
d41b37f: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
0ea1e0f: 8272902: Bump update version for OpenJDK: jdk-11.0.14
... and 49 more: https://git.openjdk.java.net/jdk11u-dev/compare/5ce46d9679fd9c9010bcfe55fd723a0f068b3333...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

buddyliao · 2021-09-08T00:06:25Z

/integrate

openjdk · 2021-09-08T00:07:52Z

@buddyliao
Your change (at version d220790) is now ready to be sponsored by a Committer.

RealCLanger · 2021-09-08T05:11:06Z

/sponsor

openjdk · 2021-09-08T05:12:24Z

Going to push as commit 085dbe3.
Since your change was applied there have been 59 commits pushed to the master branch:

2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
569688f: 8272316: Wrong Boot JDK help message in 11
1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
2908bbd: 8270216: [macOS] Update named used for Java run loop mode
ea1a1d8: 8251377: [macos11] JTabbedPane selected tab text is barely legible
9a5ba0b: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead
d41b37f: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
0ea1e0f: 8272902: Bump update version for OpenJDK: jdk-11.0.14
... and 49 more: https://git.openjdk.java.net/jdk11u-dev/compare/5ce46d9679fd9c9010bcfe55fd723a0f068b3333...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-09-08T05:12:38Z

@RealCLanger @buddyliao Pushed as commit 085dbe3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8266352: Add parallel heap iteration for jmap -histo

a2fe90d

8215624: Add parallel heap iteration for jmap histo 8253763: ParallelObjectIterator should have virtual destructor

openjdk bot added the rfr Pull request is ready for review label Jul 13, 2021

buddyliao changed the title ~~8266352: Add parallel heap iteration for jmap -histo~~ 8215624: Add parallel heap iteration for jmap –histo Jul 13, 2021

buddyliao changed the title ~~8215624: Add parallel heap iteration for jmap –histo~~ Backport 3498a10a2b4cfcdf219b4433124a2358eb6100c9 Jul 14, 2021

openjdk bot changed the title ~~Backport 3498a10a2b4cfcdf219b4433124a2358eb6100c9~~ 8215624: Add parallel heap iteration for jmap –histo Jul 14, 2021

openjdk bot added the backport label Jul 14, 2021

Merge branch 'master' into parallel_heap_iter

d220790

buddyliao mentioned this pull request Aug 24, 2021

8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id #284

Closed

3 tasks

schmelter-sap reviewed Sep 7, 2021

View reviewed changes

RealCLanger approved these changes Sep 7, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2021

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 8, 2021

openjdk bot closed this Sep 8, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8215624: Add parallel heap iteration for jmap –histo #127

8215624: Add parallel heap iteration for jmap –histo #127

buddyliao commented Jul 13, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jul 13, 2021

buddyliao commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

mlbridge bot commented Jul 13, 2021 •

edited

Loading

openjdk bot commented Jul 14, 2021

buddyliao commented Aug 17, 2021

RealCLanger commented Aug 23, 2021

RealCLanger commented Aug 23, 2021

buddyliao commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

buddyliao commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

buddyliao commented Aug 24, 2021

RealCLanger commented Aug 24, 2021

buddyliao commented Aug 24, 2021

buddyliao commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

buddyliao commented Aug 25, 2021 •

edited

Loading

RealCLanger commented Aug 27, 2021

schmelter-sap left a comment

openjdk bot commented Sep 7, 2021 •

edited

Loading

buddyliao commented Sep 8, 2021

openjdk bot commented Sep 8, 2021

RealCLanger commented Sep 8, 2021

openjdk bot commented Sep 8, 2021

openjdk bot commented Sep 8, 2021

8215624: Add parallel heap iteration for jmap –histo #127

8215624: Add parallel heap iteration for jmap –histo #127

Conversation

buddyliao commented Jul 13, 2021 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

bridgekeeper bot commented Jul 13, 2021

buddyliao commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

mlbridge bot commented Jul 13, 2021 • edited Loading

Webrevs

openjdk bot commented Jul 14, 2021

buddyliao commented Aug 17, 2021

RealCLanger commented Aug 23, 2021

RealCLanger commented Aug 23, 2021

buddyliao commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

buddyliao commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

buddyliao commented Aug 24, 2021

RealCLanger commented Aug 24, 2021

buddyliao commented Aug 24, 2021

buddyliao commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

openjdk bot commented Aug 24, 2021

buddyliao commented Aug 25, 2021 • edited Loading

RealCLanger commented Aug 27, 2021

schmelter-sap left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 7, 2021 • edited Loading

buddyliao commented Sep 8, 2021

openjdk bot commented Sep 8, 2021

RealCLanger commented Sep 8, 2021

openjdk bot commented Sep 8, 2021

openjdk bot commented Sep 8, 2021

buddyliao commented Jul 13, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Jul 13, 2021 •

edited

Loading

buddyliao commented Aug 25, 2021 •

edited

Loading

openjdk bot commented Sep 7, 2021 •

edited

Loading