Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247676: vcruntime140_1.dll is not needed on 32-bit Windows #1275

Closed
wants to merge 4 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 26, 2022

depends on #1247. CC @GoeLin who requested this backport be raised in parallel.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8247676: vcruntime140_1.dll is not needed on 32-bit Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1275/head:pull/1275
$ git checkout pull/1275

Update a local copy of the PR:
$ git checkout pull/1275
$ git pull https://git.openjdk.org/jdk11u-dev pull/1275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1275

View PR using the GUI difftool:
$ git pr show -t 1275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1275.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bcc668b77f0a0c22db49ef048286a9df5c04a308 8247676: vcruntime140_1.dll is not needed on 32-bit Windows Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 26, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jul 28, 2022

Hi George,
will this be clean if you backport it on top of 1247?
Are you aware of the possibility to have dependent pull requests? You can make a pull request on top of the branch of 1247. This is the common way if you backport a change and a follow up fix.
Also, please only add jdk11u-fix-request if you have the change reviewed!
Further, you need to get the tests green here in the PR, or at least check them that the failure is unrelated. If you do so, note it down in a comment.
I will again remove the jdk11u-fix-request tags.
Have you ever read the instructions about making changes in 11/17? https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix

Also, somewhere you state that the risk of the backport is low because the change applies clean.
That is not the kind of risk I consider when approving a backport.
The question is: might the change introduce an error that crashes the VM? Will it change the behaviour of the VM? Will it somehow require users to adapt something? E.g. the need to install a different vcruntime would be a risk. If users don't do so they will break their system when updating.

@gdams gdams changed the base branch from master to pr/1247 July 28, 2022 08:33
@openjdk openjdk bot added the clean label Jul 28, 2022
@gdams
Copy link
Member Author

gdams commented Jul 28, 2022

@GoeLin as per @RealCLanger's comment here (#1265 (review)). The GHA failure is unrelated and a known intermittent issue.

I've changed the base so that this PR is now correctly setup as a dependant PR (and marked as clean)

@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@gdams gdams changed the base branch from pr/1247 to master September 2, 2022 10:49
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8247676: vcruntime140_1.dll is not needed on 32-bit Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@gdams
Copy link
Member Author

gdams commented Sep 2, 2022

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@gdams
Your change (at version c4ea0b1) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

Going to push as commit 78ba1e5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 2, 2022
@openjdk openjdk bot closed this Sep 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@RealCLanger @gdams Pushed as commit 78ba1e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the vs2019 branch September 2, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants