New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8247676: vcruntime140_1.dll is not needed on 32-bit Windows #1275
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Hi George, Also, somewhere you state that the risk of the backport is low because the change applies clean. |
@GoeLin as per @RealCLanger's comment here (#1265 (review)). The GHA failure is unrelated and a known intermittent issue. I've changed the base so that this PR is now correctly setup as a dependant PR (and marked as clean) |
dec71c5
to
c5d1997
Compare
@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
@gdams This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
|
/integrate |
/sponsor |
Going to push as commit 78ba1e5. |
@RealCLanger @gdams Pushed as commit 78ba1e5. |
depends on #1247. CC @GoeLin who requested this backport be raised in parallel.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1275/head:pull/1275
$ git checkout pull/1275
Update a local copy of the PR:
$ git checkout pull/1275
$ git pull https://git.openjdk.org/jdk11u-dev pull/1275/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1275
View PR using the GUI difftool:
$ git pr show -t 1275
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1275.diff