Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283493: Create an automated regression test for RFE 4231298 #1287

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 29, 2022

I backport this for parity with 11.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283493: Create an automated regression test for RFE 4231298

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1287/head:pull/1287
$ git checkout pull/1287

Update a local copy of the PR:
$ git checkout pull/1287
$ git pull https://git.openjdk.org/jdk11u-dev pull/1287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1287

View PR using the GUI difftool:
$ git pr show -t 1287

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1287.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6917c39e450e0564b8db7c96be132881a6b0a112 8283493: Create an automated regression test for RFE 4231298 Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283493: Create an automated regression test for RFE 4231298

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Aug 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 1, 2022

Going to push as commit fc4868e.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 672e3c2: 8282789: Create a regression test for the JTree usecase of JDK-4618767
  • a92d71d: 8280913: Create a regression test for JRootPane.setDefaultButton() method
  • 4b85189: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test
  • d928ab7: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java
  • 3957731: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2022
@openjdk openjdk bot closed this Aug 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2022
@openjdk
Copy link

openjdk bot commented Aug 1, 2022

@GoeLin Pushed as commit fc4868e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant