New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8291570: [TESTBUG] Part of JDK-8250984 absent from 11u #1289
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 65 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks @mrserb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see |
/integrate |
Going to push as commit 2f0f34c.
Your commit was automatically rebased without conflicts. |
@gnu-andrew Pushed as commit 2f0f34c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
So, the story goes:
OSCONTAINER_ERROR
(which is-2
) as a valid return value from the CGroups v2 code.Without this fix, we're seeing the testcase failing on newer systems. This change syncs the testcase with trunk.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1289/head:pull/1289
$ git checkout pull/1289
Update a local copy of the PR:
$ git checkout pull/1289
$ git pull https://git.openjdk.org/jdk11u-dev pull/1289/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1289
View PR using the GUI difftool:
$ git pr show -t 1289
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1289.diff