Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test #1295

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 1, 2022

I backport this for parity with 11.0.17-oracle.

Clean backport from 17. 17 includes a test infra file needed for the backport.
I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test
  • JDK-8284898: Enhance PassFailJFrame

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1295/head:pull/1295
$ git checkout pull/1295

Update a local copy of the PR:
$ git checkout pull/1295
$ git pull https://git.openjdk.org/jdk11u-dev pull/1295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1295

View PR using the GUI difftool:
$ git pr show -t 1295

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1295.diff

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused here.

The original patch contains the file test/jdk/java/awt/regtesthelpers/PassFailJFrame.java which is missing from this patch.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 37c9cd1555484db9c47d97cb21aa3259519fb2fc 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test Aug 1, 2022
@openjdk
Copy link

openjdk bot commented Aug 1, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 1, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Aug 2, 2022

Sorry, I just forgot to git add the file. Fixed. t is unchanged from 17.

@tstuefe
Copy link
Member

tstuefe commented Aug 2, 2022

Sorry, I just forgot to git add the file. Fixed. t is unchanged from 17.

No problem. I thought you wanted to test me. :-)

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test
8284898: Enhance PassFailJFrame

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 2, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Aug 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2022

Going to push as commit 74daa99.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2022
@openjdk openjdk bot closed this Aug 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2022
@openjdk
Copy link

openjdk bot commented Aug 7, 2022

@GoeLin Pushed as commit 74daa99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8283803 branch August 7, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants