New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267880: Upgrade the default PKCS12 MAC algorithm #1296
Conversation
2d0604c
to
cfab060
Compare
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
Webrevs
|
cfab060
to
ca4059d
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
but be aware of the issues described here https://bugs.openjdk.org/browse/JDK-8267599
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. |
/integrate |
Going to push as commit 9cf9879.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.17-oracle.
In 11.0.12, "JDK-8153005 Upgrade the default PKCS12 encryption/MAC algorithms" was pushed.
Some parts of it were reverted right away in "JDK-8267599 Revert the change to the default PKCS12 macAlgorithm and macIterationCount props for 11u/8u/7u".
This change now again enables 8153005. It is basically the reverse patch of 8267599,
where ParamsTest.java has been renamed to KeytoolOpensslInteropTest.java.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1296/head:pull/1296
$ git checkout pull/1296
Update a local copy of the PR:
$ git checkout pull/1296
$ git pull https://git.openjdk.org/jdk11u-dev pull/1296/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1296
View PR using the GUI difftool:
$ git pr show -t 1296
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1296.diff