Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263531: Remove unused buffer int #130

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 13, 2021

The change for JDK-8257001 left an obsolete int field. Remove it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/130/head:pull/130
$ git checkout pull/130

Update a local copy of the PR:
$ git checkout pull/130
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 130

View PR using the GUI difftool:
$ git pr show -t 130

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/130.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 13, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ca806ef31970e2d020e631d55b44cfe30e11c5ca 8263531: Remove unused buffer int Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263531: Remove unused buffer int

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 23918db: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • d4e4828: 8270196: [11u] [JVMCI] JavaType.toJavaName() returns incorrect type name for lambdas
  • 8d1e402: 8265132: C2 compilation fails with assert "missing precedence edge"
  • cbd3b0f: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion
  • 09c6af3: 8249899: jdk/javadoc/tool/InlineTagsWithBraces.java uses @ignore w/o bug-id
  • 22a4752: 8268360: Missing check for infinite loop during node placement
  • 1960a05: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE
  • 6d0945e: 8217825: Verify @AfterTest is used correctly in WebSocket tests
  • 3869a19: 8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference
  • 2c49cca: 8240555: Using env of JAVA_TOOL_OPTIONS and _JAVA_OPTIONS breaks QuietOption.java test
  • ... and 31 more: https://git.openjdk.java.net/jdk11u-dev/compare/f31c90f539fe1b14ec56c94cfc63df2aaf4c1e2b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jul 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 13, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

Going to push as commit 10bbe2f.
Since your change was applied there have been 47 commits pushed to the master branch:

  • dff3b7f: 8267459: Pasting Unicode characters into JShell does not work.
  • 2252165: 8268362: [REDO] C2 crash when compile negative Arrays.copyOf length after loop
  • 8008d33: 8269304: Regression ~5% in 2005 in b27
  • 7a61e03: 8268347: C2: nested locks optimization may create unbalanced monitor enter/exit code
  • 93f952c: 8269882: stack-use-after-scope in NewObjectA
  • c9a8220: 8268620: InfiniteLoopException test may fail on x86 platforms
  • 23918db: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • d4e4828: 8270196: [11u] [JVMCI] JavaType.toJavaName() returns incorrect type name for lambdas
  • 8d1e402: 8265132: C2 compilation fails with assert "missing precedence edge"
  • cbd3b0f: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion
  • ... and 37 more: https://git.openjdk.java.net/jdk11u-dev/compare/f31c90f539fe1b14ec56c94cfc63df2aaf4c1e2b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@RealCLanger Pushed as commit 10bbe2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant