Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285693: Create an automated test for JDK-4702199 #1306

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 2, 2022

I backport this for parity with 11.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285693: Create an automated test for JDK-4702199

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1306/head:pull/1306
$ git checkout pull/1306

Update a local copy of the PR:
$ git checkout pull/1306
$ git pull https://git.openjdk.org/jdk11u-dev pull/1306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1306

View PR using the GUI difftool:
$ git pr show -t 1306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1306.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 158d871d0574970c9e5609dd037aaa0ead668a3b 8285693: Create an automated test for JDK-4702199 Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285693: Create an automated test for JDK-4702199

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 954d57a: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Aug 3, 2022

Pre-submit test hangs. unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Aug 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2022

Going to push as commit 0106d84.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 9180dcb: 8284077: Create an automated test for JDK-4170173
  • ce8367f: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small
  • 1c96cac: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • ac89673: 8290000: Bump macOS GitHub actions to macOS 11
  • d647021: 8283624: Create an automated regression test for RFE-4390885
  • 9796aac: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues
  • 3210c99: 8283245: Create a test for JDK-4670319
  • 7318cdc: 8221871: javadoc should not set role=region on
    elements
  • 93666ae: 8218413: make reconfigure ignores configure-time AUTOCONF environment variable
  • 954d57a: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2022
@openjdk openjdk bot closed this Aug 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@GoeLin Pushed as commit 0106d84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant