Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233712: Limit default tests jobs based on ulimit -u setting #1308

Closed
wants to merge 3 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Aug 3, 2022

Applies cleanly. This backport is a prerequisite to landing #1277


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233712: Limit default tests jobs based on ulimit -u setting

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1308/head:pull/1308
$ git checkout pull/1308

Update a local copy of the PR:
$ git checkout pull/1308
$ git pull https://git.openjdk.org/jdk11u-dev pull/1308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1308

View PR using the GUI difftool:
$ git pr show -t 1308

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1308.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into pr/1307 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 753c58b7f556fedd7828da487a34b8b228785ff9 8233712: Limit default tests jobs based on ulimit -u setting Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Aug 3, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2022

Webrevs

@gdams gdams changed the base branch from pr/1307 to pr/1302 August 3, 2022 10:10
@openjdk openjdk bot removed the clean label Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@gdams this pull request can not be integrated into pr/1302 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout ulimit
git fetch https://git.openjdk.org/jdk11u-dev pr/1302
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/1302"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Aug 3, 2022
@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@gdams gdams changed the base branch from pr/1302 to master August 3, 2022 10:25
@gdams gdams changed the base branch from master to pr/1302 August 3, 2022 10:25
@openjdk openjdk bot added clean and removed merge-conflict Pull request has merge conflict with target branch labels Aug 3, 2022
@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAP nightlies passed.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1302 to master August 4, 2022 07:28
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout ulimit
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233712: Limit default tests jobs based on ulimit -u setting

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2022
@openjdk openjdk bot added the clean label Aug 4, 2022
@gdams
Copy link
Member Author

gdams commented Aug 4, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@gdams
Your change (at version 91a28d4) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

Going to push as commit 08e51f5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2022
@openjdk openjdk bot closed this Aug 4, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 4, 2022
@gdams gdams deleted the ulimit branch August 4, 2022 08:33
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@RealCLanger @gdams Pushed as commit 08e51f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants